Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbbBSJc4 (ORCPT ); Thu, 19 Feb 2015 04:32:56 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:11788 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbbBSJcy (ORCPT ); Thu, 19 Feb 2015 04:32:54 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 19 Feb 2015 01:32:04 -0800 Date: Thu, 19 Feb 2015 10:32:34 +0100 From: Thierry Reding To: Arnd Bergmann CC: David Airlie , , Vincent Palatin , Andrew Bresticker , Sean Paul , Rahul Sharma , Ajay Kumar , "Javier Martinez Canillas" , Inki Dae , Sjoerd Simons , Gustavo Padovan , , Subject: Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib Message-ID: <20150219093233.GF5086@ulmo.nvidia.com> References: <19803561.otRxsE7o5u@wuerfel> MIME-Version: 1.0 In-Reply-To: <19803561.otRxsE7o5u@wuerfel> X-NVConfidentiality: public User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [10.2.70.36] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL102.nvidia.com (10.26.138.15) Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2464 Lines: 63 --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2015 at 05:09:25PM +0100, Arnd Bergmann wrote: > The ptn3460 driver recently started usign the gpiod interface > which is only available on platforms that come with GPIOLIB > support, resulting in a compile-time error: >=20 > drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable': > drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of fun= ction 'gpiod_set_value' [-Werror=3Dimplicit-function-declaration] > gpiod_set_value(ps8622->gpio_rst, 0); > ^ > drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe': > drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of fun= ction 'devm_gpiod_get' [-Werror=3Dimplicit-function-declaration] > ps8622->gpio_slp =3D devm_gpiod_get(dev, "sleep"); > ^ >=20 > Similarly, the newly added ps8622 driver started out with the same > problem. >=20 > This patch adds explicit Kconfig dependencies to avoid trying to > build invalid configurations. >=20 > Signed-off-by: Arnd Bergmann > Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 br= idge") > Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface") Applied, thanks. Thierry --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU5a2xAAoJEN0jrNd/PrOhHs4QAI6fm3zHKwmmu9fPdcVU0oPp oc7q9u8aqRSWnkNPlWAFEHw3lETkw23OSyflBUjrk+Ui2MDb/i4zSCi8kWckXI3r UK/KfxP9LpRF++OzytzcUVRiv2v5wgCx/bHk1Y5bkJimc6YH3mssFTEpESKpbf3B 4ONxysHCEBu2lCk56AIWdzS9B+cruVgxGZraL6JUb4drOYc25tO2Z2Y08nq7Y3GR /g9bggxMVgKXBSY82Ot7lR+pdZPxOORtqNn2Y4Wdk8cSEh+ptC/3doX0z2jWHJib LyXi1LLQo5TgF3FcVrsSSXbcg4H4ycVmfVdY7OBOQmNkNzSipVohw7RnNjmzs+4w MJmtXmWanFaNMhcwSNR7BqFubP2VWEHrcVsQ6VUWa4DzZNUopoTNsU1iA2Tz45O6 ED3IStpsJ/DK3fgZ3bDVPYHCwz0Oc9ugeMq0fHGJHb3Lz/Yy2S2WJlg8bOX58Yp7 VyRUycMSKjxKPLgJ3IfIxwS7Qs8j5yI/AVLBzigPd1nSwkKE0H4EfI2j4H85BgtH 21DG/pntF3PaHjTTzPLXF65Y1z0AMVf2kJ5/PutPsbzBNBgDbvFEbfKKi0ckKX+K KJ2ZQaSy3Bu2ICpuc2q7UskcowqBjLJMaHfyJa6xz4ARSDQ9BBWKreGgg2LJEqpZ KtVF4X6qFKhy0dzWodKu =+7Em -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/