Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883AbbBSJpY (ORCPT ); Thu, 19 Feb 2015 04:45:24 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45129 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136AbbBSJpV (ORCPT ); Thu, 19 Feb 2015 04:45:21 -0500 Date: Thu, 19 Feb 2015 18:44:25 +0900 From: Mark Brown To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Sangbeom Kim , alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vincent Palatin , Doug Anderson , Javier Martinez Canillas , Tomasz Figa , Kukjin Kim , Jaroslav Kysela , Takashi Iwai Message-ID: <20150219094425.GB3198@finisterre.sirena.org.uk> References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-6-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ" Content-Disposition: inline In-Reply-To: <1424283959-16289-6-git-send-email-afaerber@suse.de> X-Cookie: Are we not men? User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 175.126.181.17 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 41 --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas F=E4rber wrote: > static const struct of_device_id snow_of_match[] =3D { > + { .compatible =3D "google,snow-audio-max98089", }, > { .compatible =3D "google,snow-audio-max98090", }, > { .compatible =3D "google,snow-audio-max98091", }, > { .compatible =3D "google,snow-audio-max98095", }, Since we completely ignore the CODEC in the property might it not be better to just add a plain old snow-audio compatible and bind to that, that way we don't need these driver updates? Just the "snow" bit should be enough to know it's one of this class of machines. --3uo+9/B/ebqu+fSQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU5bB5AAoJECTWi3JdVIfQrvMH/jQFZat83HOXGQ6uN6UfGyOp EL/5IynL/XJOM9WRGk/9LCH2BITnrIECC4k2zIOflnzaCe0aLspAY9cdC2XjZroM iiRrOAC0a8OM9GmshJt1uatdoIdAJF+Xs2zaxqXzEgqaIdDtUJSG0rjlo/xA0+gU ITpKI9u5fOTO6GpEskBCbs28EL9zW1lAXciMm2aiEbRdPlhHBywmroBQzjuI3RlE hkehhi2xSWrMqbN9gbEks3kRB/2AUvCjeCFDwlp4Fuid3DsP7QEKAYR2rLvCU8IN ZpJ+7cqgzvK3l/lSlkJ9RAeKHIYxsux9U/OZWFm2873BJ/MhFs1jigTko67W36s= =o+MI -----END PGP SIGNATURE----- --3uo+9/B/ebqu+fSQ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/