Date: Thu, 19 Feb 2015 10:53:43 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, rjw@rjwysocki.net,
        tglx@linutronix.de
Subject: Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based
 broadcasting
Message-ID: <20150219095343.GF5029@twins.programming.kicks-ass.net>
References: <20150216121435.203983131@infradead.org>
 <20150216122413.880378334@infradead.org>
 <54E2BDA1.3040003@linux.vnet.ibm.com>
 <20150217103946.GD21418@twins.programming.kicks-ass.net>
 <54E402BC.2010709@linux.vnet.ibm.com>
 <20150218130614.GT5029@twins.programming.kicks-ass.net>
 <54E58A61.60200@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54E58A61.60200@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1206
Lines: 28

On Thu, Feb 19, 2015 at 12:31:53PM +0530, Preeti U Murthy wrote:
> On 02/18/2015 06:36 PM, Peter Zijlstra wrote:
> > On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote:
> >>
> >> Look at the changelog, 
> > 
> > Heh, yah, clearly I tl;dr'd that. Indeed.
> > 
> >> it explains why tick_takeover must be called
> >> *before* __cpu_die(). 
> > 
> > Since you reported this, can you test if things work if you move that
> > function call to before __cpu_die() ?
> 
> Yes it does. I had tested and posted out a patch to fix the issue
> here:https://lkml.org/lkml/2015/1/30/821. I see now that tglx proposes
> to get rid of "taking over" tick duties going forward, rather "handing
> over" tick duties would be better. So the patch in the above link would
> not be acceptable. But minus the taking over of the do_timer, the cpu
> doing the hotplug takes over broadcast duty before __cpu_die() in this
> patch. This design works.

Great, /me amends patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/