Message-ID: <54E5B6D6.6000308@nexus-software.ie>
Date: Thu, 19 Feb 2015 10:11:34 +0000
From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: kbuild test robot <fengguang.wu@intel.com>
CC: kbuild-all@01.org, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org, Andy Shevchenko <andy.schevchenko@gmail.com>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        Darren Hart <dvhart@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/intel/quark: fix simple_return.cocci warnings
References: <201502191606.pTcFEBOs%fengguang.wu@intel.com> <20150219081432.GA21996@waimea>
In-Reply-To: <20150219081432.GA21996@waimea>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1236
Lines: 39

On 19/02/15 08:14, kbuild test robot wrote:
> arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified
>
>   Simplify a trivial if-return sequence.  Possibly combine with a
>   preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
>
> CC: Bryan O'Donoghue <pure.logic@nexus-software.ie>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
>   imr.c |    6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> --- a/arch/x86/platform/intel-quark/imr.c
> +++ b/arch/x86/platform/intel-quark/imr.c
> @@ -126,12 +126,8 @@ static int imr_read(struct imr_device *i
>   	if (ret)
>   		return ret;
>
> -	ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
> +	return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
>   				reg++, &imr->wmask);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
>   }
>
>   /**
>

This flow was a change asked for and supplied in review feedback for 
Andy Shevchenko so NAK to this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/