Message-ID: <54E5B6FA.7030807@nexus-software.ie>
Date: Thu, 19 Feb 2015 10:12:10 +0000
From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: kbuild test robot <fengguang.wu@intel.com>
CC: kbuild-all@01.org, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org, Andy Shevchenko <andy.schevchenko@gmail.com>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        Darren Hart <dvhart@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/intel/quark: fix ptr_ret.cocci warnings
References: <201502191606.pTcFEBOs%fengguang.wu@intel.com> <20150219081432.GA21983@waimea>
In-Reply-To: <20150219081432.GA21983@waimea>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1128
Lines: 39

On 19/02/15 08:14, kbuild test robot wrote:
> arch/x86/platform/intel-quark/imr.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
>   Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> CC: Bryan O'Donoghue <pure.logic@nexus-software.ie>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
>   imr.c |    5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- a/arch/x86/platform/intel-quark/imr.c
> +++ b/arch/x86/platform/intel-quark/imr.c
> @@ -277,10 +277,7 @@ static int imr_debugfs_register(struct i
>   {
>   	idev->file = debugfs_create_file("imr_state", S_IFREG | S_IRUGO, NULL,
>   					 idev, &imr_state_ops);
> -	if (IS_ERR(idev->file))
> -		return PTR_ERR(idev->file);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(idev->file);
>   }
>
>   /**
>

This is a reasonable change.

ACK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/