Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbbBSLHk (ORCPT ); Thu, 19 Feb 2015 06:07:40 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:37083 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbbBSLHi (ORCPT ); Thu, 19 Feb 2015 06:07:38 -0500 To: dave@stgolabs.net Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, takedakn@nttdata.co.jp, linux-security-module@vger.kernel.org Subject: Re: [PATCH 3/3] tomoyo: robustify handling of mm->exe_file From: Tetsuo Handa References: <1424304641-28965-1-git-send-email-dbueso@suse.de> <1424304641-28965-4-git-send-email-dbueso@suse.de> <1424324307.18191.5.camel@stgolabs.net> In-Reply-To: <1424324307.18191.5.camel@stgolabs.net> Message-Id: <201502192007.AFI30725.tHFFOOMVFOQSLJ@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Thu, 19 Feb 2015 20:07:31 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 37 Thank you, but I think this patch is wrong and redundant. Davidlohr Bueso wrote: > On Wed, 2015-02-18 at 16:10 -0800, Davidlohr Bueso wrote: > > +static const char *tomoyo_get_exe(struct mm_struct *mm) > > +{ > > + struct file *exe_file; > > + const char *cp = NULL; > > + > > + if (!mm) > > + return NULL; > > + exe_file = get_mm_exe_file(mm); > > + if (!exe_file) > > + return NULL; > > + > > + cp = tomoyo_realpath_from_path(&exe_file->f_path); > > tomoyo_realpath_from_path can return NULL here, thus we'd leak the > f_path in the caller... I guess this should be: > > > + path_get(&exe_file->f_path); > > if (cp) > path_get(&exe_file->f_path); > Why do we need to let the caller call path_put() ? There is no need to do like proc_exe_link() does, for tomoyo_get_exe() returns pathname as "char *". > > + fput(exe_file); > > + return cp; > > +} -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/