Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752949AbbBSLUG (ORCPT ); Thu, 19 Feb 2015 06:20:06 -0500 Received: from down.free-electrons.com ([37.187.137.238]:44340 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752220AbbBSLUD (ORCPT ); Thu, 19 Feb 2015 06:20:03 -0500 Date: Thu, 19 Feb 2015 12:17:15 +0100 From: Maxime Ripard To: Robert Jarzmik Cc: Ezequiel Garcia , David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt Message-ID: <20150219111715.GS25269@lukather> References: <1424203617-29431-1-git-send-email-robert.jarzmik@free.fr> <20150218101646.GO25269@lukather> <87vbiz87j2.fsf@free.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ctZH5Gqgrl5HoVnD" Content-Disposition: inline In-Reply-To: <87vbiz87j2.fsf@free.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2136 Lines: 59 --ctZH5Gqgrl5HoVnD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2015 at 06:16:17PM +0100, Robert Jarzmik wrote: > >> @@ -1672,7 +1688,8 @@ static int alloc_nand_resource(struct platform_d= evice *pdev) > >> /* initialize all interrupts to be disabled */ > >> disable_int(info, NDSR_MASK); > >> =20 > >> - ret =3D request_irq(irq, pxa3xx_nand_irq, 0, pdev->name, info); > >> + ret =3D request_threaded_irq(irq, pxa3xx_nand_irq, > >> + pxa3xx_nand_irq_thread, 0, pdev->name, info); > > > > Using IRQF_ONESHOT would allow you not to do the interrupt enable / > > disable dance. > > Yes, that's a very good point. Would your Tested-by still hold with > this change ? Yep, I actually tested it before suggesting it. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --ctZH5Gqgrl5HoVnD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU5cY7AAoJEBx+YmzsjxAgsXUP/jk43vrBHLy8yKOC6H9HUTBr TBJxoQYY10+3vzBwACsGQqQy4ETrFr58xaR5d2vtEVqHDl/lOzxp7ToAbox1jApb khZisJ4vZLbZbxvkrlcnf9jTG6KY3M6kTRrH5hXSwgBHXl4JLR23ODUgfGHlkGyn 4gHENkQ/pSFsXSN8mxwbVIdkIunrz+FY4IRG/U2kDaeYN35ZL3ghStocKbsP+4cU polcIAxigY5IvSn1+wpx9jNRG3VyA7pZT6yuNusmymV0kcWU6+gqNK35rrs6wp0L 0Vurs+eUPN64t3n8OGPetx0FHqeOTXMBm3eM2I+OqRfqFLQ/eovjPnFKT4GaFW8o yZSYPj8WCnHSETsJjzXaiIaqkVgtak+1XWz3ib45LfZkGXqtkfYY6iOjIfqM1Q6n /GjQNiDMmqut8c1SMi+wvo7+Wq2HNjTLPXuiDJOKVAcUqIJl5dbpY+SP7Fx7XoFk qIQXVfkmYC6b1H8cOAfSb5eh6aw/iew6o4dyOXhZltN1wfQ0LmBBJiHIsHEYFNHa 4MpdDwW6YFxa8aEFjRlaBWydKtmM/9ceAwDqWycT+iJ2OEASBCe76mq0fqaUCPN+ iRevLsULwhHfj2aCCX1kFMiwgs47LfJQbpwcZaxXeAN9fdc6WpFp8tnPHOdh5FrN ARTGYO+lVYA5dBMsR7/s =U1Eh -----END PGP SIGNATURE----- --ctZH5Gqgrl5HoVnD-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/