Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943AbbBSOuV (ORCPT ); Thu, 19 Feb 2015 09:50:21 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:43182 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbbBSOuT (ORCPT ); Thu, 19 Feb 2015 09:50:19 -0500 Message-ID: <1424357415.4942.118.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [RESEND PATCH] ipv4: ip_check_defrag should correctly check return value of skb_copy_bits From: Eric Dumazet To: Alexander Drozdov Cc: "David S. Miller" , Alexey Kuznetsov , James Morris , ideaki YOSHIFUJI , Patrick McHardy , Eric Dumazet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Berg Date: Thu, 19 Feb 2015 06:50:15 -0800 In-Reply-To: <1424337992-8854-1-git-send-email-al.drozdov@gmail.com> References: <1424337992-8854-1-git-send-email-al.drozdov@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1498 Lines: 39 On Thu, 2015-02-19 at 12:26 +0300, Alexander Drozdov wrote: > skb_copy_bits() returns zero on success and a negative value on error, > so it is needed to invert the condition in ip_check_defrag(). > > Fixes: 1bf3751ec90c ("ipv4: ip_check_defrag must not modify skb before unsharing") > Signed-off-by: Alexander Drozdov > Acked-by: Eric Dumazet > Cc: Johannes Berg > --- > net/ipv4/ip_fragment.c | 2 +- No need to resend, your first patch is still active in patchwork. David is probably traveling from Ottawa. vi +100 Documentation/networking/netdev-FAQ.txt Q: I sent a patch and I'm wondering what happened to it. How can I tell whether it got merged? A: Start by looking at the main patchworks queue for netdev: http://patchwork.ozlabs.org/project/netdev/list/ The "State" field will tell you exactly where things are at with your patch. Q: The above only says "Under Review". How can I find out more? A: Generally speaking, the patches get triaged quickly (in less than 48h). So be patient. Asking the maintainer for status updates on your patch is a good way to ensure your patch is ignored or pushed to the bottom of the priority list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/