Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbbBSQUj (ORCPT ); Thu, 19 Feb 2015 11:20:39 -0500 Received: from sauhun.de ([89.238.76.85]:55399 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbbBSQUi (ORCPT ); Thu, 19 Feb 2015 11:20:38 -0500 Date: Thu, 19 Feb 2015 17:20:36 +0100 From: Wolfram Sang To: Russell King - ARM Linux Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: return proper ERR_PTR for clk_get when !HAVE_CLK Message-ID: <20150219162036.GB1664@katana> References: <1423163365-15267-1-git-send-email-wsa@the-dreams.de> <20150205234040.GV8656@n2100.arm.linux.org.uk> <20150207164209.GA6263@katana> <20150207172949.GE8656@n2100.arm.linux.org.uk> <20150209142954.GA8024@katana> <20150210110242.GI8656@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i0/AhcQY5QxfSsSZ" Content-Disposition: inline In-Reply-To: <20150210110242.GI8656@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 44 --i0/AhcQY5QxfSsSZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Back from a HDD crash... > The "test-for-zero-clock-rate" method I showed in my previous email > will work for you - and will avoid using this hateful macro while > still giving the behaviour you desire, and you won't be caring about > the detail of the clk API implementation either. The resume path needed fixing, too. I'll send the patch right away. --i0/AhcQY5QxfSsSZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU5g1UAAoJEBQN5MwUoCm2Ql4P/2lCHhEm2aB3IpEQgDLni8Kl y/Fu210JtNBE4YMFxK4r7IGN69hesOVdg95N61Fptrfsa2S/yq0VuigBv3kidJ0s gC/dyr9BVvBKLRm+M1RiNaHidz6aTTDt0Zp+Gm5kC2aqFFCh9hzGVVLXAuI1RpeS qStDW21gsOLzNmRKc8hIS7N/5Aob4k1DJPL2S324/SQg2Rzyg1rzMLGFvofEyQ6w ThK6ghWEnqi9ayEFhAelCgSUpD3EukJDVqZ9g4OZ4CSHp2ObWct7stUd8jn22LxW NYENoM6jRPLIEF51aO3GQMkxQxV5qcCSDWmFLkwNNJWKphBoI79UE3FuoF7CMqUp 9Lir95EqdjMaxTEP+hk2Go20WFqePms1jWDjhDmx5QUOovBC6IXZ+SagxkGglCmj oU9kX6op/OsDsA2VsTDhwsO454lkUPnskenoL0RY6igGP5cylfvAR3IFSh+X8jJK Kh6lwh2ggX9fuPLQ8bjbzs+EWfFyKJTdzaa6Wtvj7x7HTi/CMch0azIbi21+jrB5 742esmfKLSVx3y5SqE8qjGqXlpopFdQT3T55qVquTXn2dI9GwloqmHmQyf0YZL0E /NVaIxlbvS/FTptsYPJZcgfCEL4d+Z9sysvWTdB6lhZr1MFWDeKwTw+JBBGEzm1E 9xtPKnRluXujdJ8t1wFs =egTg -----END PGP SIGNATURE----- --i0/AhcQY5QxfSsSZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/