Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbbBSRoN (ORCPT ); Thu, 19 Feb 2015 12:44:13 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:35536 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbbBSRoK convert rfc822-to-8bit (ORCPT ); Thu, 19 Feb 2015 12:44:10 -0500 MIME-Version: 1.0 In-Reply-To: <20150219094425.GB3198@finisterre.sirena.org.uk> References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-6-git-send-email-afaerber@suse.de> <20150219094425.GB3198@finisterre.sirena.org.uk> Date: Thu, 19 Feb 2015 09:44:08 -0800 X-Google-Sender-Auth: hr7YrsDkhABZ1I0SkMlRbKouNk4 Message-ID: Subject: Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089 From: Doug Anderson To: Mark Brown Cc: =?UTF-8?Q?Andreas_F=C3=A4rber?= , Sangbeom Kim , alsa-devel@alsa-project.org, linux-samsung-soc , Liam Girdwood , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Vincent Palatin , Javier Martinez Canillas , Tomasz Figa , Kukjin Kim , Jaroslav Kysela , Takashi Iwai , Olof Johansson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 37 Mark, On Thu, Feb 19, 2015 at 1:44 AM, Mark Brown wrote: > On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote: > >> static const struct of_device_id snow_of_match[] = { >> + { .compatible = "google,snow-audio-max98089", }, >> { .compatible = "google,snow-audio-max98090", }, >> { .compatible = "google,snow-audio-max98091", }, >> { .compatible = "google,snow-audio-max98095", }, > > Since we completely ignore the CODEC in the property might it not be > better to just add a plain old snow-audio compatible and bind to that, > that way we don't need these driver updates? Just the "snow" bit should > be enough to know it's one of this class of machines. I think what you're suggesting is that here we should add a new compatible string "google,snow-audio" instead of adding "google,snow-audio-max98089" here. Then the sound node in the spring DTS would look like: compatible = "google,snow-audio-max98089", "google,snow-audio"; That would allow us to later figure out that we're on a board with max98089 in case it became important but means that any other minor tweaks like this wouldn't need anything special. I haven't tried that to make sure that the fallback compatible string actually works in this case, but it seems like the right way to go... Sound good? -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/