Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbbBSSkx (ORCPT ); Thu, 19 Feb 2015 13:40:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40651 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883AbbBSSkm (ORCPT ); Thu, 19 Feb 2015 13:40:42 -0500 Message-ID: <54E62E1C.4030105@suse.de> Date: Thu, 19 Feb 2015 19:40:28 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Doug Anderson CC: Javier Martinez Canillas , alsa-devel@alsa-project.org, linux-samsung-soc , Sangbeom Kim , Liam Girdwood , Mark Brown , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Vincent Palatin , Tomasz Figa , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH 1/6] ASoC: max98088: Document DT bindings References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-2-git-send-email-afaerber@suse.de> <54E5EB36.9020007@collabora.co.uk> <54E5EF73.2090302@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2247 Lines: 53 Am 19.02.2015 um 18:48 schrieb Doug Anderson: > On Thu, Feb 19, 2015 at 6:13 AM, Andreas Färber wrote: >>> I see that a master clock (mclk) is added in patch 6/6 but the >>> max98088 codec driver does handle this clock. >>> >>> If the SoC XCLKOUT provides the master clock to the max98089 >>> codec in Spring like is the case for the max9809{0,5} codecs >>> in the Snow and Peach Pit/Pi Chromebooks then you need to do >>> something along the lines of the following commits: >>> >>> e3048c3d2be5 ASoC: max98095: Add master clock handling >>> b10ab7b838bd ASoC: max98090: Add master clock handling >>> >>> If that's the case you also have to mention in the DT binding >>> doc that "clocks" and "clock-names" are optional properties >>> like Documentation/devicetree/bindings/sound/max9809{0,5}.txt. >> >> When I prepared this patch, I believe it was a straight copy from >> max98090. Sounds like they changed since then. >> >> My 6/6 adopted the mclk clock from your now-cancelled v2 patch for Snow, >> assuming it would be the same on all Chromebooks. I tested that last >> change by checking for errors in dmesg. >> >> Doug, can you advise on how the clock wiring is for Spring? > > I can confirm that XCLKOUT is connected to the codec MCLK on the > Spring schematics I have. Thanks! I updated max98088 and had it working on first boot, but on second boot it complained about the frequency: [ 7.896834] max98088 7-0010: revision A [ 7.912776] snow-audio sound: HiFi <-> 3830000.i2s mapping ok [ 7.919367] max98088 7-0010: Invalid master clock frequency [ 7.919429] snow-audio sound: ASoC: Spring-I2S-MAX98089 late_probe() failed: -22 [ 7.920019] snow-audio sound: snd_soc_register_card failed (-22) [ 7.920109] snow-audio: probe of sound failed with error -22 Will investigate. Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/