Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbbBSTKf (ORCPT ); Thu, 19 Feb 2015 14:10:35 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:56134 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbbBSTKd (ORCPT ); Thu, 19 Feb 2015 14:10:33 -0500 Date: Thu, 19 Feb 2015 14:10:28 -0500 (EST) Message-Id: <20150219.141028.571019196212537944.davem@davemloft.net> To: joseph@codesourcery.com Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, kkojima@rr.iij4u.or.jp Subject: Re: [PATCH RFC] Update kernel math-emu code from current glibc soft-fp From: David Miller In-Reply-To: References: <20150219.132122.204795202277130266.davem@davemloft.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Feb 2015 11:10:33 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 33 From: Joseph Myers Date: Thu, 19 Feb 2015 18:40:34 +0000 > On Thu, 19 Feb 2015, David Miller wrote: > >> From: Joseph Myers >> Date: Fri, 6 Feb 2015 17:25:29 +0000 >> >> > * On SPARC, comparisons now use raw unpacking (this should not in fact >> > change how the emulation behaves, just make it more efficient). >> >> I did a sparc64 test build and it failed like so: ... > Please try this patch on top of the previous one. The way abort is > redefined in the kernel code doesn't work for one place using it in an > expression; this patch changes a comma expression to a statement > expression. This didn't appear in my powerpc testing because the powerpc > emulation never uses FP_FROM_INT; I'm not sure how Kaz's sh testing > avoided the problem appearing there. > > diff --git a/include/math-emu/op-common.h b/include/math-emu/op-common.h > index b9f5e1a..8c059c3 100644 > --- a/include/math-emu/op-common.h > +++ b/include/math-emu/op-common.h That fixes the build for 64-bit sparc, thanks Joseph. I'll try to do some functional testing now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/