Date: Thu, 19 Feb 2015 20:13:21 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@gmail.com>, Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>,
        John Stultz <john.stultz@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>, Pawel Moll <pawel.moll@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 0/2] perf/x86: Add ability to sample TSC
Message-ID: <20150219191321.GA12008@gmail.com>
References: <1424347870-8492-1-git-send-email-adrian.hunter@intel.com>
 <20150219135002.GJ5029@twins.programming.kicks-ass.net>
 <54E5F581.9000205@intel.com>
 <20150219150543.GE21418@twins.programming.kicks-ass.net>
 <54E607AE.8080707@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54E607AE.8080707@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1087
Lines: 29


* Adrian Hunter <adrian.hunter@intel.com> wrote:

> > I suspect you're talking about something else entirely; 
> > your changelogs are inadequate for they tell ntohing of 
> > your usecase and have me guessing. Don't do that.
> 
> Sorry. I did mention Intel PT in patch 2, but I basically 
> assumed the need to synchronize events with other time 
> sources was understood.

Written down, slightly repetitive walk-throughs from first 
concepts to implementation that don't assume too much 
context are very useful to us slightly overworked 
maintainers with an attention span of a slightly retarded 
golden retriever. (Make the story interesting and mix in a 
few jokes and you've got our attention for sure!)

So please do explain verbosely, especially if a review 
discussion turns somewhat discordant, it's a useful tool.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/