Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbbBSUJO (ORCPT ); Thu, 19 Feb 2015 15:09:14 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:57039 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbbBSUJM (ORCPT ); Thu, 19 Feb 2015 15:09:12 -0500 Date: Thu, 19 Feb 2015 15:09:09 -0500 (EST) Message-Id: <20150219.150909.1111353454350810861.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net-next v2 0/3] Adjust the settings about USB_RX_EARLY_AGG From: David Miller In-Reply-To: <1394712342-15778-141-Taiwan-albertk@realtek.com> References: <1394712342-15778-137-Taiwan-albertk@realtek.com> <1394712342-15778-141-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Feb 2015 12:09:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 37 From: Hayes Wang Date: Thu, 12 Feb 2015 14:33:45 +0800 > v2: > For patch #1, replace > > u32 ocp_data; > ocp_data = tp->coalesce / 8; > > with > > u32 ocp_data = tp->coalesce / 8; > > And replace > > struct net_device *dev = tp->netdev; > u32 ocp_data; > ocp_data = (agg_buf_sz - dev->mtu - VLAN_ETH_HLEN - VLAN_HLEN) / 4; > > with > > u32 mtu = tp->netdev->mtu; > u32 ocp_data = (agg_buf_sz - mtu - VLAN_ETH_HLEN - VLAN_HLEN) / 4; > > Use *switch* statement to replace the checking of *if*. > > v1: > The USB_RX_EARLY_AGG contains timeout and size. Separate them, and > they could be set independently. Then, the ethtool could be used to > change the timeout according to situation of the platform. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/