Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688AbbBTAHQ (ORCPT ); Thu, 19 Feb 2015 19:07:16 -0500 Received: from mail.skyhub.de ([78.46.96.112]:48537 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbbBTAHO (ORCPT ); Thu, 19 Feb 2015 19:07:14 -0500 Date: Fri, 20 Feb 2015 01:06:20 +0100 From: Borislav Petkov To: Adrien Schildknecht Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, rostedt@goodmis.org, heukelum@fastmail.fm, luto@amacapital.net, adech.fo@gmail.com, masami.hiramatsu.pt@hitachi.com, akpm@linux-foundation.org, a.ryabinin@samsung.com, fruggeri@arista.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86: fix output of show_stack_log_lvl() Message-ID: <20150220000620.GC31467@pd.tnic> References: <1424385796-28910-1-git-send-email-adrien+dev@schischi.me> <1424385796-28910-2-git-send-email-adrien+dev@schischi.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1424385796-28910-2-git-send-email-adrien+dev@schischi.me> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 39 On Thu, Feb 19, 2015 at 11:43:15PM +0100, Adrien Schildknecht wrote: > Prepend the log level at the message following a newline. > It is not possible to use pr_cont after a newline, the log level will be > reseted. > > Signed-off-by: Adrien Schildknecht > --- > arch/x86/kernel/dumpstack_32.c | 9 ++++++--- > arch/x86/kernel/dumpstack_64.c | 9 ++++++--- > 2 files changed, 12 insertions(+), 6 deletions(-) So those two patches belong into one as they logically are one fix. Please merge them. Then, please change your commit message to the format: "Problem is A. We need to do B. This patch does it or this patch does C in order fix it." Something like that in free form. Being verbose is a good thing when explaning why this fix is needed and for people looking at those commit messages months and years from now. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/