Date: Thu, 19 Feb 2015 23:45:48 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Adrien Schildknecht <adrien+dev@schischi.me>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        heukelum@fastmail.fm, luto@amacapital.net, adech.fo@gmail.com,
        masami.hiramatsu.pt@hitachi.com, akpm@linux-foundation.org,
        a.ryabinin@samsung.com, fruggeri@arista.com, bp@alien8.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()
Message-ID: <20150219234548.2e4412cb@grimm.local.home>
In-Reply-To: <1424399661-20327-1-git-send-email-adrien+dev@schischi.me>
References: <1424385796-28910-1-git-send-email-adrien+dev@schischi.me>
	<1424399661-20327-1-git-send-email-adrien+dev@schischi.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1201
Lines: 30

On Fri, 20 Feb 2015 03:34:21 +0100
Adrien Schildknecht <adrien+dev@schischi.me> wrote:

> show_stack_log_lvl() does not set the log level after a new line,
> the following messages printed with pr_cont are thus assigned to the
> default log level.

This looks like a bug in printk(). Why doesn't pr_cont() continue? It
shouldn't care if there's a newline or not. pr_cont() is supposed to
continue whatever the last printk log level was.

If this is broken here, it's probably broken elsewhere. The fix is to
fix printk, not to hunt and peck for the places with work arounds that
are broken by it.

-- Steve

> This patch prepends the log level to the next message following a new
> line.
> 
> print_trace_address() uses printk(log_lvl). Using printk with just
> a log level is ignored and thus has no effect on the next pr_cont.
> We need to prepend the log level directly into the message.
> 
> Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/