Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754351AbbBTK1v (ORCPT ); Fri, 20 Feb 2015 05:27:51 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:42786 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046AbbBTK1s (ORCPT ); Fri, 20 Feb 2015 05:27:48 -0500 Message-ID: <54E70C10.5050102@oracle.com> Date: Fri, 20 Feb 2015 05:27:28 -0500 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stefan Strogin , "linux-mm@kvack.org" , linux-kernel@vger.kernel.org, akpm@linux-foundation.org CC: iamjoonsoo.kim@lge.com, m.szyprowski@samsung.com, lauraa@codeaurora.org Subject: Re: [PATCH v5 2/3] mm: cma: allocation trigger References: <1423780008-16727-1-git-send-email-sasha.levin@oracle.com> <1423780008-16727-3-git-send-email-sasha.levin@oracle.com> <54E61F91.9080506@partner.samsung.com> In-Reply-To: <54E61F91.9080506@partner.samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2389 Lines: 74 Stefan, Andrew, I ended up cherry-picking and older patch here by mistake. Joonsoo pointed it out but I didn't have time to address it yet since I'm travelling and they got pulled in to mmotm in the meanwhile. I'll send out patches to add documentation and fix the issues raised here early next week. Sorry for the delay and the noise. Thanks, Sasha On 02/19/2015 12:38 PM, Stefan Strogin wrote: > Hi, > > On 13/02/15 01:26, Sasha Levin wrote: >> Provides a userspace interface to trigger a CMA allocation. >> >> Usage: >> >> echo [pages] > alloc >> >> This would provide testing/fuzzing access to the CMA allocation paths. >> >> Signed-off-by: Sasha Levin >> --- >> mm/cma.c | 6 ++++++ >> mm/cma.h | 4 ++++ >> mm/cma_debug.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- >> 3 files changed, 64 insertions(+), 2 deletions(-) >> >> diff --git a/mm/cma_debug.c b/mm/cma_debug.c >> index 3a25413..5bd6863 100644 >> --- a/mm/cma_debug.c >> +++ b/mm/cma_debug.c >> @@ -23,8 +32,48 @@ static int cma_debugfs_get(void *data, u64 *val) >> >> DEFINE_SIMPLE_ATTRIBUTE(cma_debugfs_fops, cma_debugfs_get, NULL, "%llu\n"); >> >> -static void cma_debugfs_add_one(struct cma *cma, int idx) >> +static void cma_add_to_cma_mem_list(struct cma *cma, struct cma_mem *mem) >> +{ >> + spin_lock(&cma->mem_head_lock); >> + hlist_add_head(&mem->node, &cma->mem_head); >> + spin_unlock(&cma->mem_head_lock); >> +} >> + >> +static int cma_alloc_mem(struct cma *cma, int count) >> +{ >> + struct cma_mem *mem; >> + struct page *p; >> + >> + mem = kzalloc(sizeof(*mem), GFP_KERNEL); >> + if (!mem) >> + return -ENOMEM; >> + >> + p = cma_alloc(cma, count, CONFIG_CMA_ALIGNMENT); > > If CONFIG_DMA_CMA (and therefore CONFIG_CMA_ALIGNMENT) isn't configured > then building fails. >> mm/cma_debug.c: In function ‘cma_alloc_mem’: >> mm/cma_debug.c:223:28: error: ‘CONFIG_CMA_ALIGNMENT’ undeclared (first use in this function) >> p = cma_alloc(cma, count, CONFIG_CMA_ALIGNMENT); >> ^ > > Also, could you please fix the whitespace errors in your patches? > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/