Date: Fri, 20 Feb 2015 11:38:45 +0100
From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Adrien Schildknecht <adrien+dev@schischi.me>, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, x86@kernel.org, rostedt@goodmis.org,
        heukelum@fastmail.fm, luto@amacapital.net, adech.fo@gmail.com,
        masami.hiramatsu.pt@hitachi.com, akpm@linux-foundation.org,
        a.ryabinin@samsung.com, fruggeri@arista.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()
Message-ID: <20150220103845.GB19378@pd.tnic>
References: <1424385796-28910-1-git-send-email-adrien+dev@schischi.me>
 <1424399661-20327-1-git-send-email-adrien+dev@schischi.me>
 <20150220081003.GA20216@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150220081003.GA20216@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1287
Lines: 42

On Fri, Feb 20, 2015 at 09:10:03AM +0100, Ingo Molnar wrote:
> This approach looks good to me, we want to print multi-line 
> messages with the same consistent loglevel.

Right, I'll pick this one up for now as it is obviously correct and
whatever we end up doing to pr_cont() won't influence it.

> Totally unrelated observation #2:
> 
> >  		if (kstack_end(stack))
> >  			break;
> > -		if (i && ((i % STACKSLOTS_PER_LINE) == 0))
> > -			pr_cont("\n");
> 
> > +++ b/arch/x86/kernel/dumpstack_64.c
> 
> >  		if (((long) stack & (THREAD_SIZE-1)) == 0)
> >  			break;
> >  		}
> > -		if (i && ((i % STACKSLOTS_PER_LINE) == 0))
> > -			pr_cont("\n");
> 
> Looks like kstack_end() could be defined on 64-bit as well, 
> unifying the stack printing logic some more?
> 
> ( I'd no go so far as to unify the two functions, but the 
>   closer to each other the better it is to make changes 
>   that affect both of them. )

Adrien, want to take care of that one too?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/