Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754703AbbBTOCA (ORCPT ); Fri, 20 Feb 2015 09:02:00 -0500 Received: from nbfkord-smmo01.seg.att.com ([209.65.160.76]:17720 "EHLO nbfkord-smmo01.seg.att.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754513AbbBTOB6 (ORCPT ); Fri, 20 Feb 2015 09:01:58 -0500 X-Greylist: delayed 614 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 Feb 2015 09:01:58 EST X-MXL-Hash: 54e73e564c4bdc2f-76d466a3182195ed67ea9aeac28870fe9073e5c8 X-MXL-Hash: 54e73bf06b175959-bfa856215923061fee024d219b47bc6810b51b40 Message-ID: <54E73BE4.2040505@solarflare.com> Date: Fri, 20 Feb 2015 13:51:32 +0000 From: Edward Cree User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Hiroshi Shimamoto CC: "Skidmore, Donald C" , "vyasevic@redhat.com" , "Kirsher, Jeffrey T" , Alexander Duyck , =?UTF-8?B?QmrDuHJuIE1vcms=?= , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma Subject: Re: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E38840@BPXM14GP.gisp.nec.co.jp> In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05E38840@BPXM14GP.gisp.nec.co.jp> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.20.45] X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-21346.005 X-TM-AS-Result: No--9.988100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.0 cv=D4Dw3Itj c=1 sm=1 a=MkjXnYnS3dyNWGSWLXxFFQ==:17 a] X-AnalysisOut: [=mypmul4OXYAA:10 a=fVG4DLb5TBsA:10 a=BLceEmwcHowA:10 a=Ikc] X-AnalysisOut: [TkHD0fZMA:10 a=zRKbQ67AAAAA:8 a=0HtSIViG9nkA:10 a=nrACCIEE] X-AnalysisOut: [AAAA:8 a=yvqDhQrFjj1UGef7XfQA:9 a=QEXdDO2ut3YA:10] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2014051901)] X-MAIL-FROM: X-SOURCE-IP: [12.187.104.25] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 28 On 20/02/15 01:00, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Add netlink directives and ndo entry to allow VF multicast promiscuous mode. > > The administrator wants to allow dedicatedly multicast promiscuous per VF. If I'm properly understanding, this seems to be an ixgbe-specific option to work around an ixgbe limitation; is it really appropriate to implement as a generic net_device_op? What would this ndo mean to a driver which can support thousands of multicast groups without MC promisc? Is it expected to limit the number of MC groups when this is set to disallow? Or just fulfil the letter of the option but not its spirit? The option doesn't seem to have well-defined semantics outside of ixgbe. I would suggest that the right place for this sort of driver-specific device control is in sysfs. I'm also a little perplexed as to why anyone would need to disallow this; what security, or even administrative convenience, is gained by allowing a VF to join 30 multicast groups but not multicast promiscuous mode? Especially as, afaik, there are no restrictions on which multicast groups are joined, so the VF can receive any particular multicast traffic it cares about. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/