Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbbBTPA4 (ORCPT ); Fri, 20 Feb 2015 10:00:56 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:48199 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755085AbbBTPAy (ORCPT ); Fri, 20 Feb 2015 10:00:54 -0500 Date: Fri, 20 Feb 2015 16:00:46 +0100 From: Michael Mueller To: Alexander Graf Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models Message-ID: <20150220160046.4743acc8@bee> In-Reply-To: <54E73C8F.7000202@suse.de> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com> <54E73C8F.7000202@suse.de> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022015-0041-0000-0000-00000351B024 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 33 On Fri, 20 Feb 2015 14:54:23 +0100 Alexander Graf wrote: > > > > +/* machine related properties */ > > +typedef struct S390CPUMachineProps { > > + uint16_t class; /* machine class */ > > + uint16_t ga; /* availability number of machine */ > > + uint16_t order; /* order of availability */ > > +} S390CPUMachineProps; > > + > > +/* processor related properties */ > > +typedef struct S390CPUProcessorProps { > > + uint16_t gen; /* S390 CMOS generation */ > > + uint16_t ver; /* version of processor */ > > + uint32_t id; /* processor identification*/ > > + uint16_t type; /* machine type */ > > + uint16_t ibc; /* IBC value */ > > + uint64_t *fac_list; /* list of facilities */ > > Just make this uint64_t fac_list[2]. That way we don't have to track any > messy allocations. It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB not just 16 bytes but I will change it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/