Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755085AbbBTPCe (ORCPT ); Fri, 20 Feb 2015 10:02:34 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:39919 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754434AbbBTPCc (ORCPT ); Fri, 20 Feb 2015 10:02:32 -0500 Date: Fri, 20 Feb 2015 16:02:22 +0100 From: Michael Mueller To: Alexander Graf Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models Message-ID: <20150220160222.4a7817d7@bee> In-Reply-To: <54E73CD4.8080506@suse.de> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com> <54E73CD4.8080506@suse.de> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022015-0025-0000-0000-000003F78F43 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 25 On Fri, 20 Feb 2015 14:55:32 +0100 Alexander Graf wrote: > > /** > > * S390CPUClass: > > * @parent_realize: The parent class' realize handler. > > @@ -52,6 +69,11 @@ typedef struct S390CPUClass { > > void (*load_normal)(CPUState *cpu); > > void (*cpu_reset)(CPUState *cpu); > > void (*initial_cpu_reset)(CPUState *cpu); > > + bool is_active[ACCEL_ID_MAX]; /* model enabled for given host and accel */ > > + bool is_host[ACCEL_ID_MAX]; /* model markes host for given accel */ > > + uint64_t *fac_list; /* active facility list */ > > + S390CPUMachineProps *mach; /* machine specific properties */ > > + S390CPUProcessorProps *proc; /* processor specific properties */ > > Sorry, same here. Just put the structs straight into the class struct. Yep, consistent. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/