Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbbBTPWX (ORCPT ); Fri, 20 Feb 2015 10:22:23 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42412 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753233AbbBTPWV convert rfc822-to-8bit (ORCPT ); Fri, 20 Feb 2015 10:22:21 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models From: Alexander Graf X-Mailer: iPhone Mail (12B411) In-Reply-To: <20150220160046.4743acc8@bee> Date: Fri, 20 Feb 2015 16:22:20 +0100 Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gleb Natapov , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Content-Transfer-Encoding: 8BIT Message-Id: <89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com> <54E73C8F.7000202@suse.de> <20150220160046.4743acc8@bee> To: Michael Mueller Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 38 > Am 20.02.2015 um 16:00 schrieb Michael Mueller : > > On Fri, 20 Feb 2015 14:54:23 +0100 > Alexander Graf wrote: > >>> >>> +/* machine related properties */ >>> +typedef struct S390CPUMachineProps { >>> + uint16_t class; /* machine class */ >>> + uint16_t ga; /* availability number of machine */ >>> + uint16_t order; /* order of availability */ >>> +} S390CPUMachineProps; >>> + >>> +/* processor related properties */ >>> +typedef struct S390CPUProcessorProps { >>> + uint16_t gen; /* S390 CMOS generation */ >>> + uint16_t ver; /* version of processor */ >>> + uint32_t id; /* processor identification*/ >>> + uint16_t type; /* machine type */ >>> + uint16_t ibc; /* IBC value */ >>> + uint64_t *fac_list; /* list of facilities */ >> >> Just make this uint64_t fac_list[2]. That way we don't have to track any >> messy allocations. > > It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB not > just 16 bytes but I will change it. Why? Do we actually need that many? This is a qemu internal struct. Alex-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/