Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754753AbbBTPcW (ORCPT ); Fri, 20 Feb 2015 10:32:22 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:57693 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754442AbbBTPcV (ORCPT ); Fri, 20 Feb 2015 10:32:21 -0500 Date: Fri, 20 Feb 2015 16:32:09 +0100 From: Michael Mueller To: Alexander Graf Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines Message-ID: <20150220163209.4e082e0b@bee> In-Reply-To: <54E73EB2.6050700@suse.de> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-14-git-send-email-mimu@linux.vnet.ibm.com> <54E73EB2.6050700@suse.de> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022015-0041-0000-0000-00000351CCC5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 55 On Fri, 20 Feb 2015 15:03:30 +0100 Alexander Graf wrote: > > > > - s390_get_proceccor_props() > > - s390_set_proceccor_props() > > > > They can be used to request or retrieve processor related information from an accelerator. > > That information comprises the cpu identifier, the ICB value and the facility lists. > > > > Signed-off-by: Michael Mueller > > Hrm, I still seem to miss the point of this interface. What do you need > it for? These functions make the internal s390 cpu model API independent from a specific accelerator: int s390_set_processor_props(S390ProcessorProps *prop) { if (kvm_enabled()) { return kvm_s390_set_processor_props(prop); } return -ENOSYS; } It's called by: s390_select_cpu_model(const char *model) which is itself called by: S390CPU *cpu_s390x_init(const char *cpu_model) { S390CPU *cpu; cpu = S390_CPU(object_new(s390_select_cpu_model(cpu_model))); object_property_set_bool(OBJECT(cpu), true, "realized", NULL); return cpu; } So above s390_set/get_processor_props() the code is accelerator independent. Michael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/