Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754930AbbBTQEV (ORCPT ); Fri, 20 Feb 2015 11:04:21 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:34236 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754902AbbBTQET convert rfc822-to-8bit (ORCPT ); Fri, 20 Feb 2015 11:04:19 -0500 Date: Fri, 20 Feb 2015 17:04:08 +0100 From: Michael Mueller To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: Alexander Graf , qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines Message-ID: <20150220170408.49db6da5@bee> In-Reply-To: <54E755BD.5000705@suse.de> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-14-git-send-email-mimu@linux.vnet.ibm.com> <54E73EB2.6050700@suse.de> <20150220163209.4e082e0b@bee> <54E755BD.5000705@suse.de> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022016-0009-0000-0000-00000337530D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1759 Lines: 56 On Fri, 20 Feb 2015 16:41:49 +0100 Andreas Färber wrote: > Can't you just implement the class-level name-to-ObjectClass callback > that other CPUs have grown for the above use case? If it fulfills the requirements sure. Please point me to an example, sounds that s390_select_cpu_model() is doing something similar to that, just that it hooks in the s390_set_processor_props() call. const char *s390_select_cpu_model(const char *model) { S390ProcessorProps proc; const char *typename; S390CPUClass *cc; /* return already selected cpu typename */ typename = s390_cpu_typename(); if (typename) { goto out; } /* return standard cpu typename when cpu models are unavailable */ typename = TYPE_S390_CPU; if (!s390_cpu_classes_initialized() || !model) { goto out; } cc = S390_CPU_CLASS(s390_cpu_class_by_name(model)); if (!cc) { goto out; } proc.cpuid = cpuid(cc->proc); proc.ibc = cc->proc->ibc; memcpy(proc.fac_list, cc->fac_list, S390_ARCH_FAC_LIST_SIZE_BYTE); if (s390_set_processor_props(&proc)) { goto out; } /* return requested cpu typename in success case */ typename = object_class_get_name((ObjectClass *) cc); out: selected_cpu_typename = typename; trace_select_cpu_model(model, typename); return typename; } > > Also a general comment: cpu-model/ is not an existing directory nor one > you add, so please use "target-s390x: Add foo to S390CPU" or so. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/