Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbbBTQNE (ORCPT ); Fri, 20 Feb 2015 11:13:04 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:37039 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754761AbbBTQNA (ORCPT ); Fri, 20 Feb 2015 11:13:00 -0500 Date: Fri, 20 Feb 2015 17:12:49 +0100 From: Michael Mueller To: Richard Henderson Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , frank.blaschka@de.ibm.com Subject: Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines Message-ID: <20150220171249.210a0236@bee> In-Reply-To: <54E75AA2.9070503@twiddle.net> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-11-git-send-email-mimu@linux.vnet.ibm.com> <54E75AA2.9070503@twiddle.net> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022016-0009-0000-0000-000003375B11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 33 On Fri, 20 Feb 2015 08:02:42 -0800 Richard Henderson wrote: > > +/** > > + * s390_test_facility - test if given facility bit is set facility list > > + * of given cpu class > > + * @class: address of cpu class to test > > + * @nr: bit number to test > > + * > > + * Returns: true in case it is set > > + * false in case it is not set > > + */ > > +bool s390_test_facility(S390CPUClass *cc, unsigned long nr) > > +{ > > + if (cc) { > > + return test_facility(nr, cc->fac_list) ? true : false; > > + } > > + return false; > > +} > > Where do you see this being used? Good spot, it's not being used yet. It's planned to be used with a patch that implements zPCI related instructions on QEMU side. Maybe you have seen the discussion from Frank Blaschka in this e-mail list in regard to that. Michael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/