Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754974AbbBTQxb (ORCPT ); Fri, 20 Feb 2015 11:53:31 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:50062 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754473AbbBTQxa convert rfc822-to-8bit (ORCPT ); Fri, 20 Feb 2015 11:53:30 -0500 Date: Fri, 20 Feb 2015 17:53:21 +0100 From: Michael Mueller To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: Alexander Graf , qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines Message-ID: <20150220175321.63fc8e3a@bee> In-Reply-To: <54E7609E.6020302@suse.de> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-14-git-send-email-mimu@linux.vnet.ibm.com> <54E73EB2.6050700@suse.de> <20150220163209.4e082e0b@bee> <54E755BD.5000705@suse.de> <20150220170408.49db6da5@bee> <54E7609E.6020302@suse.de> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022016-0041-0000-0000-000003520B2D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 31 On Fri, 20 Feb 2015 17:28:14 +0100 Andreas Färber wrote: Andreas, > Sorry for my ignorance, but what is proc actually needed for? For > initializing the class, there's .class_init (and cc->fac_list apparently > is initialized here). If you need to pass info to KVM, you can do so in yes, it is communication to the accelerator to prepare its local cpu model related data structures which are used to initialize a vcpu (e.g. the facility list beside others) > DeviceClass::realize when the vCPU actually goes "live". A I will look what "goes live" in detail means here, it should at least be before kvm_arch_vcpu_setup() gets triggered on accelerator side. > string-to-string (or string-to-ObjectClass) translation function seems > like a weird point in time to take action with global effect. > > Anyway, please implement the generic callback, then you can still call > it from your own helper functions if needed. Thanks a lot! Michael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/