Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755147AbbBTQ7T (ORCPT ); Fri, 20 Feb 2015 11:59:19 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49574 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754429AbbBTQ7R (ORCPT ); Fri, 20 Feb 2015 11:59:17 -0500 Message-ID: <54E767E2.4060100@suse.de> Date: Fri, 20 Feb 2015 17:59:14 +0100 From: Alexander Graf User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Michael Mueller CC: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-10-git-send-email-mimu@linux.vnet.ibm.com> <54E73DB8.20902@suse.de> <20150220161805.3d04097a@bee> In-Reply-To: <20150220161805.3d04097a@bee> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 59 On 20.02.15 16:18, Michael Mueller wrote: > On Fri, 20 Feb 2015 14:59:20 +0100 > Alexander Graf wrote: > >>> +typedef struct S390ProcessorProps { >>> + uint64_t cpuid; >>> + uint16_t ibc; >>> + uint8_t pad[6]; >>> + uint64_t fac_list[S390_ARCH_FAC_LIST_SIZE_UINT64]; >>> +} S390ProcessorProps; >>> + >>> +typedef struct S390MachineProps { >>> + uint64_t cpuid; >>> + uint32_t ibc_range; >>> + uint8_t pad[4]; >>> + uint64_t fac_list_mask[S390_ARCH_FAC_LIST_SIZE_UINT64]; >>> + uint64_t fac_list[S390_ARCH_FAC_LIST_SIZE_UINT64]; >>> +} S390MachineProps; >> >> What are those structs there for? To convert between a kvm facing >> interface to an internal interface? > > Yes, that's their current use, but if the interface structs: > > +struct kvm_s390_vm_cpu_processor { > + __u64 cpuid; > + __u16 ibc; > + __u8 pad[6]; > + __u64 fac_list[256]; > +}; > + > +/* kvm S390 machine related attributes are r/o */ > +#define KVM_S390_VM_CPU_MACHINE 1 > +struct kvm_s390_vm_cpu_machine { > + __u64 cpuid; > + __u32 ibc_range; > + __u8 pad[4]; > + __u64 fac_mask[256]; > + __u64 fac_list[256]; > +}; > > are visible here, I'll reuse them... But stop, that will not work in the > --disable-kvm case... I need them! I meant it the other way around - do KVM specific patching of the cpu types from kvm.c. But please give a nutshell explanation on what exactly you're patching at all here. Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/