Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755226AbbBTRgL (ORCPT ); Fri, 20 Feb 2015 12:36:11 -0500 Received: from mail.skyhub.de ([78.46.96.112]:59653 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753863AbbBTRgK (ORCPT ); Fri, 20 Feb 2015 12:36:10 -0500 Date: Fri, 20 Feb 2015 18:35:14 +0100 From: Borislav Petkov To: Steven Rostedt Cc: Linus Torvalds , Masami Hiramatsu , Alexander van Heukelum , tglx@linutronix.de, luto@amacapital.net, fruggeri@arista.com, a.ryabinin@samsung.com, akpm@linux-foundation.org, hpa@zytor.com, Adrien Schildknecht , linux-kernel@vger.kernel.org, adech.fo@gmail.com, x86@kernel.org, mingo@redhat.com Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl() Message-ID: <20150220173514.GF19378@pd.tnic> References: <1424385796-28910-1-git-send-email-adrien+dev@schischi.me> <1424399661-20327-1-git-send-email-adrien+dev@schischi.me> <20150219234548.2e4412cb@grimm.local.home> <20150220120506.1c3812a8@grimm.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150220120506.1c3812a8@grimm.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 27 On Fri, Feb 20, 2015 at 12:05:06PM -0500, Steven Rostedt wrote: > printk: Comment pr_cont() stating it is only to continue a line > > KERN_CONT is nicely commented in kern_levels.h, but pr_cont() is now > used more often, and it lacks the comment stating what it is used for. > It can be confused as continuing the log level, but that is not its > purpose. It's purpose is to continue a line that had no newline > enclosed. This should be documented by pr_cont() as well. > > Signed-off-by: Steven Rostedt I sure could've used that info when looking at this yesterday. Good patch. Acked-by: Borislav Petkov -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/