Message-ID: <1424455404.18211.10.camel@perches.com>
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()
From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Thomas Gleixner <tglx@linutronix.de>, luto@amacapital.net,
        fruggeri@arista.com, Steven Rostedt <rostedt@goodmis.org>,
        a.ryabinin@samsung.com, akpm@linux-foundation.org, hpa@zytor.com,
        Adrien Schildknecht <adrien+dev@schischi.me>,
        linux-kernel@vger.kernel.org,
        Alexander van Heukelum <heukelum@fastmail.fm>, bp@alien8.de,
        adech.fo@gmail.com, x86@kernel.org, mingo@redhat.com
Date: Fri, 20 Feb 2015 10:03:24 -0800
In-Reply-To: <CA+55aFx8pcoGzKuTubwzcBc-0=_Eoiu2n=Ub75PDuo8GkZvyng@mail.gmail.com>
References: <1424385796-28910-1-git-send-email-adrien+dev@schischi.me>
	 <1424399661-20327-1-git-send-email-adrien+dev@schischi.me>
	 <20150219234548.2e4412cb@grimm.local.home>
	 <CA+55aFzDt_7Rs9=4XFKo0LP4iBnV4qmJWUDACtBDbV4eRE-X9A@mail.gmail.com>
	 <20150220120506.1c3812a8@grimm.local.home>
	 <1424454016.18211.8.camel@perches.com>
	 <CA+55aFx8pcoGzKuTubwzcBc-0=_Eoiu2n=Ub75PDuo8GkZvyng@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1488
Lines: 45

On Fri, 2015-02-20 at 09:52 -0800, Linus Torvalds wrote:
> On Feb 20, 2015 9:40 AM, "Joe Perches" <joe@perches.com> wrote:
> >
> > There are still a few dozen uses of this pattern:
> >
> >         pr_info("Some message line 1\nNext line: ");
> >         for (...)
> >                 pr_cont(" part %d", i);
> >         pr_cont('\n");
> 
> That, btw, is a buglet anyway.
> 
> We don't really support newlines in the middle of printouts any more. We
> used to, but it for deprecated. It doesn't really work with the "printk is
> a message packet" model.
> 
> Admittedly neither does the "pr_cont()" model, but pr_cont() is
> fundamentally useful, in a way that newlines in the middle are not (they
> can always just be split up, while the pr_cont() cannot generally be
> combined).
> 
> So we should generally try to get rid of the newline in the middle cases.

True. Also fix the pr_debug/dev_dbg cases
like drivers/dma/ppc4xx/adma.c:

static void prep_dma_pq_dbg(int id, dma_addr_t *dst, dma_addr_t *src,
			    unsigned int src_cnt)
{
	int i;

	pr_debug("\n%s(%d):\nsrc: ", __func__, id);
	for (i = 0; i < src_cnt; i++)
		pr_debug("\t0x%016llx ", src[i]);
	pr_debug("dst: ");
	for (i = 0; i < 2; i++)
		pr_debug("\t0x%016llx ", dst[i]);
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/