Date: Fri, 20 Feb 2015 19:51:03 +0100 (CET)
From: Fabian Frederick <fabf@skynet.be>
Reply-To: Fabian Frederick <fabf@skynet.be>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        netdev@vger.kernel.org, "Jan \"Yenya\" Kasprzak" <kas@fi.muni.cz>
Message-ID: <1849761882.58117.1424458263796.open-xchange@webmail.nmp.proximus.be>
In-Reply-To: <54E77E34.6050909@cogentembedded.com>
References: <1424455977-21903-1-git-send-email-fabf@skynet.be> <1424455977-21903-6-git-send-email-fabf@skynet.be> <54E77E34.6050909@cogentembedded.com>
Subject: Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by
 set_current_state()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Importance: Medium
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1043
Lines: 39


> On 20 February 2015 at 19:34 Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
>
>
> Hello.
>
> On 02/20/2015 09:12 PM, Fabian Frederick wrote:
>
> > Use helper functions to access current->state.
> > Direct assignments are prone to races and therefore buggy.
>
> > current->state = TASK_RUNNING is replaced by __set_current_state()
>
>     You sometimes use __set_current_state() and sometimes set_current_state().
Hello Sergei,

Peter suggested to use __set_current_state() for TASK_RUNNING :
http://marc.info/?l=linux-kernel&m=142442259719216&w=2

Regards,
Fabian

>
> > Thanks to Peter Zijlstra for the exact definition of the problem.
>
> > Suggested-By: Peter Zijlstra <peterz@infradead.org>
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
>
> [...]
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/