Date: Fri, 20 Feb 2015 19:53:19 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <david.ahern@oracle.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>, acme@kernel.org,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf: Only include tsc file for x86
Message-ID: <20150220185318.GA817@krava.redhat.com>
References: <1424370153-128274-1-git-send-email-david.ahern@oracle.com>
 <20150219194235.GA1707@krava.redhat.com>
 <54E6F1F0.1010508@intel.com>
 <54E76399.40105@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54E76399.40105@oracle.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1243
Lines: 31

On Fri, Feb 20, 2015 at 09:40:57AM -0700, David Ahern wrote:
> On 2/20/15 1:36 AM, Adrian Hunter wrote:
> >On 19/02/15 21:42, Jiri Olsa wrote:
> >>On Thu, Feb 19, 2015 at 01:22:33PM -0500, David Ahern wrote:
> >>>perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make
> >>>inclusion of tsc.c dependent on x86 as well.
> >>
> >>hum, should we move it to arch/x86/util/tsc.c and remove util/tsc.c?
> >
> >It is not arch-specific because you can read a perf.data file
> >from one architecture on another architecture.
> >
> >The TSC stuff was planned for Intel PT although it might now
> >be done differently.
> >
> >Probably you should have CONFIG_X86_TSC and then select that
> >with CONFIG_X86. Later it can be selected with CONFIG_INTEL_PT
> >as well.
> 
> For now let's leave it as CONFIG_X86. Right now only X86 code needs the
> functions it provides and there is no need taking any other steps until
> something is going to use it.
> 
> ie., patch is good as is. Agreed?

ook, jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/