Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754737AbbBTTD6 (ORCPT ); Fri, 20 Feb 2015 14:03:58 -0500 Received: from mail-ig0-f172.google.com ([209.85.213.172]:36867 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752566AbbBTTD4 (ORCPT ); Fri, 20 Feb 2015 14:03:56 -0500 MIME-Version: 1.0 In-Reply-To: <1423894668-8886-1-git-send-email-addy.ke@rock-chips.com> References: <1423828368-18456-1-git-send-email-addy.ke@rock-chips.com> <1423894668-8886-1-git-send-email-addy.ke@rock-chips.com> Date: Fri, 20 Feb 2015 11:03:56 -0800 X-Google-Sender-Auth: bS7MgFzMlRWuxG7b3UZUV4Iouew Message-ID: Subject: Re: [PATCH v4 0/3] about data busy From: Doug Anderson To: Addy Ke Cc: Jaehoon Chung , Ulf Hansson , Olof Johansson , Alim Akhtar , Andrzej Hajda , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Eddie Cai , lintao , Tao Huang , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2149 Lines: 55 Hi, On Fri, Feb 13, 2015 at 10:17 PM, Addy Ke wrote: > patch 1: This patch can fix bug that controller is still data busy after > reset all blocks. After this patch, I still get data busy in > set_ios(). > > patch 2: This patch fix bug 'Timeout sending command'. After patch1 and > patch2, there is no mmc errors after: > cd /sys/bus/platform/drivers/dwmmc_rockchip > for i in $(seq 1 10000); do > echo "========================" $i > echo ff0c0000.dwmmc > unbind > sleep .5 > echo ff0c0000.dwmmc > bind > sleep 2 > done > > patch3: This patch fix bug that there is data busy before sdio send CMD53. > But This patch is necessary for sd and mmc too. > > Addy Ke (3): > mmc: dw_mmc: update clock after host reach a stable voltage > mmc: dw_mmc: fix bug that cause 'Timeout sending command' > mmc: dw_mmc: Don't start command while data busy > > drivers/mmc/host/dw_mmc.c | 41 ++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) A little hard to follow all the patches flying around (so I'll probably reply a few different places with the same info), but I believe that all of Addy's patches (with the exception of the one intended to fix mmc_test which needs to be spun by him for a bugfix) can be replaced with: * mmc: dw_mmc: Don't start commands while busy https://patchwork.kernel.org/patch/5858221/ * mmc: dw_mmc: Make sure we only adjust the clock when power is on https://patchwork.kernel.org/patch/5858261/ * mmc: dw_mmc: Give a good reset after we give power https://patchwork.kernel.org/patch/5858281/ In order to avoid further spreading info out among several patches, I'd request that you don't respond here but instead respond to my posted patches. Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/