Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755291AbbBTTF3 (ORCPT ); Fri, 20 Feb 2015 14:05:29 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:40024 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755172AbbBTTF1 (ORCPT ); Fri, 20 Feb 2015 14:05:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <1423828368-18456-1-git-send-email-addy.ke@rock-chips.com> <1423894668-8886-1-git-send-email-addy.ke@rock-chips.com> <1423894668-8886-2-git-send-email-addy.ke@rock-chips.com> Date: Fri, 20 Feb 2015 11:05:26 -0800 X-Google-Sender-Auth: xqRYSohUOi2HG-eaTE05YJWtcKI Message-ID: Subject: Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage From: Doug Anderson To: Alim Akhtar , Addy Ke Cc: Jaehoon Chung , Ulf Hansson , Olof Johansson , Andrzej Hajda , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Eddie Cai , lintao , Tao Huang , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , Javier Martinez Canillas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2098 Lines: 55 Hi, On Thu, Feb 19, 2015 at 5:04 PM, Doug Anderson wrote: > Hi, > > On Thu, Feb 19, 2015 at 3:49 PM, Doug Anderson wrote: >> I've got that coded up but I'm still testing it... If you want to try >> it too, you can find it at >> . >> >> Note that without my patch I find that I _really_ need Addy's patch to >> make sure that the card isn't busy in setup_bus. With my patch Addy's >> code catches the card busy less often. I'm still trying to see if >> there's a way to totally remove the need for his setup_bus and still >> trying to grok all the patches flying around... > > Ah, this might be the magic needed: > > https://chromium-review.googlesource.com/251344 > > > I think that together with the previous patch things are happy for me > without any of Addy's patches, though it's the end of my work day and > I haven't given this nearly as much testing as I'd like. > > I'll continue testing tomorrow and then post both patches together upstream. OK, posted three patches upstream... A little hard to follow all the patches flying around (so I'll probably reply a few different places with the same info), but I believe that all of Addy's patches (with the exception of the one intended to fix mmc_test which needs to be spun by him for a bugfix) can be replaced with: * mmc: dw_mmc: Don't start commands while busy https://patchwork.kernel.org/patch/5858221/ * mmc: dw_mmc: Make sure we only adjust the clock when power is on https://patchwork.kernel.org/patch/5858261/ * mmc: dw_mmc: Give a good reset after we give power https://patchwork.kernel.org/patch/5858281/ In order to avoid further spreading info out among several patches, I'd request that you don't respond here but instead respond to my posted patches. Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/