Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755377AbbBTTJY (ORCPT ); Fri, 20 Feb 2015 14:09:24 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:37118 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754756AbbBTTJX (ORCPT ); Fri, 20 Feb 2015 14:09:23 -0500 Date: Fri, 20 Feb 2015 13:09:00 -0600 From: Felipe Balbi To: David Cohen CC: Paul Bolle , , , , , Subject: Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s) Message-ID: <20150220190900.GA9191@saruman.tx.rr.com> Reply-To: References: <1419288217-19262-1-git-send-email-david.a.cohen@linux.intel.com> <1424375984-26241-1-git-send-email-david.a.cohen@linux.intel.com> <1424385546.5308.7.camel@x220> <20150220190226.GA15303@psi-dev26.jf.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <20150220190226.GA15303@psi-dev26.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3042 Lines: 88 --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 20, 2015 at 11:02:26AM -0800, David Cohen wrote: > Hi, >=20 > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > > As always, comments are welcome. > >=20 > > Are nits welcome too? > >=20 > > > +MODULE_LICENSE("GPLv2"); > >=20 > > You probably meant > > MODULE_LICENSE("GPL v2") > >=20 > > Didn't that trigger a warning or error? >=20 > checkpatch showed no warning about that, not even with --strict option. > I believe both ways are fine. But I can add the space. Documentation says it should be with space: /* * The following license idents are currently accepted as indicating free * software modules * * "GPL" [GNU Public License v2 or later] * "GPL v2" [GNU Public License v2] * "GPL and additional rights" [GNU Public License v2 rights and more] * "Dual BSD/GPL" [GNU Public License v2 * or BSD license choice] * "Dual MIT/GPL" [GNU Public License v2 * or MIT license choice] * "Dual MPL/GPL" [GNU Public License v2 * or Mozilla license choice] * * The following other idents are available * * "Proprietary" [Non free products] * * There are dual licensed components, but when running with Linux it is the * GPL that is relevant so this is a non issue. Similarly LGPL linked with = GPL * is a GPL combined work. * * This exists for several reasons * 1. So modinfo can show license info for users wanting to vet their setup * is free * 2. So the community can ignore bug reports including proprietary modules * 3. So vendors can do likewise based on their own policies */ #define MODULE_LICENSE(_license) MODULE_INFO(license, _license) --=20 balbi --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU54ZLAAoJEIaOsuA1yqREMOcP+we9y3ITeojyndbwCnZaZamp TNLNqEn9XDiqkF/bt6604kGP2e7vdkNQdzE/ZrohpHSummdCwPb4vVKidyHIRHcj U+h2ObgmS//G0PGQG45SX/r7i/GU2PHTFfizLCvMAN+RKLc2Uncp9dHTQj+eO0Qx Jjz5nMPjH48XbagTJLluOCuOAPOU/dGu6rWKMNpUMJcbT/7RCN2h/ZLXJUNRchok 0VzVVFu07YwgA3LRHaaqRPsk5Zgsy9ogS+LzW+1zK9NtBWVNg7lAhtQygFrsp8Wc jfXinZT4ulx0tl2Ww+tsjpLwUqDfaTd0ct57xYmDl6zQ+AZsCsxzZv5DL3jrK8ED PcNXSirL2+dHmFuhMC9eFtaiG+tMFxTcCe+dSQXTjKMM/gv0I9tb2P8ud+xehh8J Hr/FDKq+hRFyXHt/kQw4BFTnASg01ABogDm4OHLrmUdeLA3JUbZPnGyalRIregCH uFh1Sa34A5WtIC9DFEVm98260tifM9zSlRcqCgYaCgf2STKfRRlmG3OQDofwxzJK S9XnU/dXZXSokRs7oUnUy+2Mpw0BFortAxmOdqBTr/gV9TPy9DfK61KFqSJSu2Z7 ueJTMtl8ZJIn7D737KRCPOVPq+czVX5OhPLLSvqEBWSTrkL2JvDWOZmFjbVwWr2T ZDGJ/X/1t6My6j0BZkqt =F9YZ -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/