Message-ID: <1424459434.5308.52.camel@x220>
Subject: Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port
 controlled by GPIO(s)
From: Paul Bolle <pebolle@tiscali.nl>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        baolu.lu@linux.intel.com
Date: Fri, 20 Feb 2015 20:10:34 +0100
In-Reply-To: <20150220190226.GA15303@psi-dev26.jf.intel.com>
References: <1419288217-19262-1-git-send-email-david.a.cohen@linux.intel.com>
	 <1424375984-26241-1-git-send-email-david.a.cohen@linux.intel.com>
	 <1424385546.5308.7.camel@x220>
	 <20150220190226.GA15303@psi-dev26.jf.intel.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 31

On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote:
> On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
> > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
> > > As always, comments are welcome.
> > 
> > Are nits welcome too?
> > 
> > > +MODULE_LICENSE("GPLv2");
> > 
> > You probably meant
> >     MODULE_LICENSE("GPL v2")
> > 
> > Didn't that trigger a warning or error?
> 
> checkpatch showed no warning about that, not even with --strict option.
> I believe both ways are fine. But I can add the space.

"GPLv2" is not mentioned in include/linux/license.h so, as I remember,
it would taint the kernel, and a warning will be printed when you load
that module.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/