Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755037AbbBTTPJ (ORCPT ); Fri, 20 Feb 2015 14:15:09 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:33653 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722AbbBTTPH (ORCPT ); Fri, 20 Feb 2015 14:15:07 -0500 Message-ID: <54E787B7.5000609@cogentembedded.com> Date: Fri, 20 Feb 2015 22:15:03 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Fabian Frederick , linux-kernel@vger.kernel.org CC: Ingo Molnar , Peter Zijlstra , Greg Kroah-Hartman , netdev@vger.kernel.org, "Jan \"Yenya\" Kasprzak" Subject: Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state() References: <1424455977-21903-1-git-send-email-fabf@skynet.be> <1424455977-21903-6-git-send-email-fabf@skynet.be> <54E77E34.6050909@cogentembedded.com> <1849761882.58117.1424458263796.open-xchange@webmail.nmp.proximus.be> In-Reply-To: <1849761882.58117.1424458263796.open-xchange@webmail.nmp.proximus.be> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 34 On 02/20/2015 09:51 PM, Fabian Frederick wrote: >>> Use helper functions to access current->state. >>> Direct assignments are prone to races and therefore buggy. >>> current->state = TASK_RUNNING is replaced by __set_current_state() >> You sometimes use __set_current_state() and sometimes set_current_state(). > Hello Sergei, > Peter suggested to use __set_current_state() for TASK_RUNNING : > http://marc.info/?l=linux-kernel&m=142442259719216&w=2 I didn't even question your decisions, I (like Peter) just wanted a more coherent change-log. Thanks to Peter for the explanations though. :-) > Regards, > Fabian >>> Thanks to Peter Zijlstra for the exact definition of the problem. >>> Suggested-By: Peter Zijlstra >>> Signed-off-by: Fabian Frederick >> [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/