Message-ID: <1424459742.18211.13.camel@perches.com>
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()
From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@amacapital.net>,
        Francesco Ruggeri <fruggeri@arista.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Andrey Ryabinin <a.ryabinin@samsung.com>,
        Andrew Morton <akpm@linux-foundation.org>, Peter Anvin <hpa@zytor.com>,
        Adrien Schildknecht <adrien+dev@schischi.me>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Alexander van Heukelum <heukelum@fastmail.fm>,
        Borislav Petkov <bp@alien8.de>, Andrey Konovalov <adech.fo@gmail.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Ingo Molnar <mingo@redhat.com>
Date: Fri, 20 Feb 2015 11:15:42 -0800
In-Reply-To: <CA+55aFzPyBMoW-BXJNvaUOHAnUe7hN+XW0sri99V_wb5pP2tTw@mail.gmail.com>
References: <1424385796-28910-1-git-send-email-adrien+dev@schischi.me>
	 <1424399661-20327-1-git-send-email-adrien+dev@schischi.me>
	 <20150219234548.2e4412cb@grimm.local.home>
	 <CA+55aFzDt_7Rs9=4XFKo0LP4iBnV4qmJWUDACtBDbV4eRE-X9A@mail.gmail.com>
	 <20150220120506.1c3812a8@grimm.local.home>
	 <1424454016.18211.8.camel@perches.com>
	 <CA+55aFx8pcoGzKuTubwzcBc-0=_Eoiu2n=Ub75PDuo8GkZvyng@mail.gmail.com>
	 <1424455404.18211.10.camel@perches.com>
	 <CA+55aFzPyBMoW-BXJNvaUOHAnUe7hN+XW0sri99V_wb5pP2tTw@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1179
Lines: 36

On Fri, 2015-02-20 at 10:51 -0800, Linus Torvalds wrote:
> On Fri, Feb 20, 2015 at 10:03 AM, Joe Perchens <joe@perches.com> wrote:
> >
> > True. Also fix the pr_debug/dev_dbg cases
> > like drivers/dma/ppc4xx/adma.c:
> 
> Yup, that's just garbage, and doesn't actually do what is intended.
> 
> Also, rather than
> 
>          pr_debug("\n%s(%d):\nsrc: ", __func__, id);
>          for (i = 0; i < src_cnt; i++)
>                  pr_debug("\t0x%016llx ", src[i]);
>         ...
> 
> t should probably just use
> 
>          pr_debug("%s(%d):\n", __func__, id);
>          pr_debug("%src: %*phN\n", src_cnt*sizeof(*src), src);
> 
> or similar. Yes, that will just print out the byte-stream rather than
> do it in chunkcs of 64-bit entries, but..

That won't work for > 64 byte output.

This would probably be better:

	print_hex_dump_debug("src: ", DUMP_PREFIX_OFFSET, 16, sizeof(*src),
			     src, src_cnt * sizeof(*src), false);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/