Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755181AbbBTUAq (ORCPT ); Fri, 20 Feb 2015 15:00:46 -0500 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:60110 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752892AbbBTUAp (ORCPT ); Fri, 20 Feb 2015 15:00:45 -0500 X-ME-Helo: beldin X-ME-Date: Fri, 20 Feb 2015 21:00:43 +0100 X-ME-IP: 90.16.210.142 From: Robert Jarzmik To: Arnd Bergmann , Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, Dmitry Eremin-Solenikov , netdev@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH] net: smc91x: improve neponset hack References: <5763365.j5Nvv4LgM3@wuerfel> <20150219003549.GY8656@n2100.arm.linux.org.uk> <5754481.gFE9BvLjh0@wuerfel> X-URL: http://belgarath.falguerolles.org/ Date: Fri, 20 Feb 2015 21:00:32 +0100 In-Reply-To: <5754481.gFE9BvLjh0@wuerfel> (Arnd Bergmann's message of "Fri, 20 Feb 2015 16:47:06 +0100") Message-ID: <87twyg73q7.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 35 Arnd Bergmann writes: > On Thursday 19 February 2015 00:35:49 Russell King - ARM Linux wrote: >> On Wed, Feb 18, 2015 at 08:47:30PM +0100, Arnd Bergmann wrote: >> > The smc91x driver tries to support multiple platforms at compile >> > time, but they are mutually exclusive at runtime, and not clearly >> > defined. >> >> I'd prefer to rework this to fix that properly. From what I remember, >> the whole SA11x0 stuff in this driver was a mess. > > I guess that's reasonable. I've looked through the driver and it seems we > did most of the multiplatform work but left a few things alone that should > have been converted a long time ago. > > Can you check if the approach below makes sense to you? > > I've verified that each machine that defines an smc91x device now sets > the correct platform data, irq flags and access width, which should be > enough to collapse all the CONFIG_ARM cases into one. > > Signed-off-by: Arnd Bergmann When you're both satisfied with the smc91x patch, I can offer to test it across the pxa boards (lubbock, zylonite, and maybe mainstone). As I'm actively using the first 2, I'm interested in them being as functional as now :) Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/