Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754537AbbBTUXV (ORCPT ); Fri, 20 Feb 2015 15:23:21 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:45995 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbBTUXU (ORCPT ); Fri, 20 Feb 2015 15:23:20 -0500 Date: Fri, 20 Feb 2015 15:23:17 -0500 (EST) Message-Id: <20150220.152317.2246116638858595617.davem@davemloft.net> To: al.drozdov@gmail.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv4: ip_check_defrag should correctly check return value of skb_copy_bits From: David Miller In-Reply-To: <1424169226-30112-1-git-send-email-al.drozdov@gmail.com> References: <1424169226-30112-1-git-send-email-al.drozdov@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Feb 2015 12:23:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 15 From: Alexander Drozdov Date: Tue, 17 Feb 2015 13:33:46 +0300 > skb_copy_bits() returns zero on success and negative value on error, > so it is needed to invert the condition in ip_check_defrag(). > > Fixes: 1bf3751ec90c ("ipv4: ip_check_defrag must not modify skb before unsharing") > Signed-off-by: Alexander Drozdov Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/