Date: Fri, 20 Feb 2015 15:50:08 -0500 (EST)
Message-Id: <20150220.155008.1982154709411369621.davem@davemloft.net>
To: geert@linux-m68k.org
Cc: therbert@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Initialize all members in skb_gro_remcsum_init()
From: David Miller <davem@davemloft.net>
In-Reply-To: <1424255886-20330-1-git-send-email-geert@linux-m68k.org>
References: <1424255886-20330-1-git-send-email-geert@linux-m68k.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1049
Lines: 22

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 18 Feb 2015 11:38:06 +0100

> skb_gro_remcsum_init() initializes the gro_remcsum.delta member only,
> leading to compiler warnings about a possibly uninitialized
> gro_remcsum.offset member:
> 
> drivers/net/vxlan.c: In function ?vxlan_gro_receive?:
> drivers/net/vxlan.c:602: warning: ?grc.offset? may be used uninitialized in this function
> net/ipv4/fou.c: In function ?gue_gro_receive?:
> net/ipv4/fou.c:262: warning: ?grc.offset? may be used uninitialized in this function
> 
> While these are harmless for now:
>   - skb_gro_remcsum_process() sets offset before changing delta,
>   - skb_gro_remcsum_cleanup() checks if delta is non-zero before
>     accessing offset,
> it's safer to let the initialization function initialize all members.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thank you.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?