Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754737AbbBTUz0 (ORCPT ); Fri, 20 Feb 2015 15:55:26 -0500 Received: from mail.skyhub.de ([78.46.96.112]:48493 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbbBTUzZ (ORCPT ); Fri, 20 Feb 2015 15:55:25 -0500 Date: Fri, 20 Feb 2015 21:54:29 +0100 From: Borislav Petkov To: Joel Schopp Cc: Gleb Natapov , Paolo Bonzini , kvm@vger.kernel.org, Joerg Roedel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: svm: use kvm_register_write()/read() Message-ID: <20150220205429.GC19589@pd.tnic> References: <20150220183939.16805.54776.stgit@joelvmguard2.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150220183939.16805.54776.stgit@joelvmguard2.amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 27 On Fri, Feb 20, 2015 at 12:39:40PM -0600, Joel Schopp wrote: > KVM has nice wrappers to access the register values, clean up a few places > that should use them but currently do not. > > Signed-off-by:David Kaplan > Signed-off-by:Joel Schopp This SOB chain looks strange. If David is the author, you want to have him in From: at the beginning of the patch. Stuff you did ontop should be in []-braces before your SOB, like this: Signed-off-by: David Kaplan [ Did this and that to patch. ] Signed-off-by: Joel Schopp -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/