Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754756AbbBTVnT (ORCPT ); Fri, 20 Feb 2015 16:43:19 -0500 Received: from mail-ie0-f171.google.com ([209.85.223.171]:45383 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbbBTVnR (ORCPT ); Fri, 20 Feb 2015 16:43:17 -0500 MIME-Version: 1.0 In-Reply-To: <1424400925-3867-1-git-send-email-addy.ke@rock-chips.com> References: <1422273849-29773-1-git-send-email-addy.ke@rock-chips.com> <1424400925-3867-1-git-send-email-addy.ke@rock-chips.com> Date: Fri, 20 Feb 2015 13:43:16 -0800 Message-ID: Subject: Re: [PATCH v2] mmc: dw_mmc: fix bug that cause mmc_test failture From: Doug Anderson To: Addy Ke Cc: Ulf Hansson , Jaehoon Chung , Olof Johansson , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Javier Martinez Canillas , Tao Huang , lintao , Eddie Cai , "open list:ARM/Rockchip SoC..." , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 39 Addy, On Thu, Feb 19, 2015 at 6:55 PM, Addy Ke wrote: > The STOP command can terminate a data transfer between a memory card and > mmc controller. > > As show in Synopsys DesignWare Cores Mobile Stroage Host Databook: > Data timeout and Data end-bit error will terminate further data transfer > by mmc controller. So we should not send abort command to terminate a > data transfer again if we got DRTO and EBE interrupt. > > After this patch, all mmc_test cases can pass on RK3288-Pink2 board. > > Signed-off-by: Addy Ke > --- > Changes in v2: > - DRTO and EBE are both set, should not send abort command too, > suggested by Doug Anderson. > > drivers/mmc/host/dw_mmc.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) I also suggested that you change the subject to "mmc: dw_mmc: fix mmc_test by not sending abort for DRTO / EBE errors" which you didn't do. ...I guess that's not critical. Perhaps Jaehoon (who is collecting patches for Ulf now I think) can adjust the subject when he applies. In any case, v2 fixes my problems and seems OK to me. Reviewed-by: Doug Anderson On rk3288 on a 3.14 kernel w/ lotsa backports: Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/