Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755037AbbBTVpA (ORCPT ); Fri, 20 Feb 2015 16:45:00 -0500 Received: from mail-bn1bon0113.outbound.protection.outlook.com ([157.56.111.113]:20544 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752566AbbBTVo6 (ORCPT ); Fri, 20 Feb 2015 16:44:58 -0500 X-WSS-ID: 0NK3B2P-07-4QG-02 X-M-MSG: Message-ID: <54E7AACF.2090707@amd.com> Date: Fri, 20 Feb 2015 15:44:47 -0600 From: Joel Schopp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Borislav Petkov CC: Gleb Natapov , Paolo Bonzini , , Joerg Roedel , Subject: Re: [PATCH] x86: svm: use kvm_register_write()/read() References: <20150220183939.16805.54776.stgit@joelvmguard2.amd.com> <20150220205429.GC19589@pd.tnic> In-Reply-To: <20150220205429.GC19589@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Joel.Schopp@amd.com; 8bytes.org; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(199003)(377454003)(51704005)(479174004)(189002)(24454002)(106466001)(65956001)(105586002)(19580395003)(19580405001)(59896002)(65806001)(92566002)(64706001)(87936001)(76176999)(87266999)(50986999)(86362001)(65816999)(83506001)(54356999)(77156002)(62966003)(46102003)(80316001)(77096005)(101416001)(23676002)(97736003)(53416004)(64126003)(36756003)(47776003)(68736005)(2950100001)(110136001)(50466002)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB040;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB040; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005003);SRVR:BN1PR02MB040; X-Forefront-PRVS: 0493852DA9 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB040; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2015 21:44:51.5129 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB040 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB104; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 25 On 02/20/2015 02:54 PM, Borislav Petkov wrote: > On Fri, Feb 20, 2015 at 12:39:40PM -0600, Joel Schopp wrote: >> KVM has nice wrappers to access the register values, clean up a few places >> that should use them but currently do not. >> >> Signed-off-by:David Kaplan >> Signed-off-by:Joel Schopp > This SOB chain looks strange. If David is the author, you want to have > him in From: at the beginning of the patch. > > Stuff you did ontop should be in []-braces before your SOB, like this: Will resend with From: line and braces for clarification. > > Signed-off-by: David Kaplan > [ Did this and that to patch. ] > Signed-off-by: Joel Schopp > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/