Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755511AbbBUCBh (ORCPT ); Fri, 20 Feb 2015 21:01:37 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46672 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754931AbbBUCBg (ORCPT ); Fri, 20 Feb 2015 21:01:36 -0500 Date: Fri, 20 Feb 2015 18:00:55 -0800 From: Andrew Morton To: Ryusuke Konishi Cc: linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Martin Schwidefsky , Heiko Carstens Subject: Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode Message-Id: <20150220180055.443bbce8.akpm@linux-foundation.org> In-Reply-To: <20150221.101328.1613471465739082397.konishi.ryusuke@lab.ntt.co.jp> References: <1424439995-613-2-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <20150220135842.0cd5c9338316a8a20b6a604a@linux-foundation.org> <20150221.092208.1795135375638032743.konishi.ryusuke@lab.ntt.co.jp> <20150221.101328.1613471465739082397.konishi.ryusuke@lab.ntt.co.jp> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 23 On Sat, 21 Feb 2015 10:13:28 +0900 (JST) Ryusuke Konishi wrote: > I've got a warning from 0day kernel testing backend: > > fs/nilfs2/btree.c: In function 'nilfs_btree_root_broken': > >> fs/nilfs2/btree.c:394:3: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'ino_t' [-Wformat=] > pr_crit("NILFS: bad btree root (inode number=%lu): level = %d, > flags = 0x%x, nchildren = %d\n", > ^ > > This is output for s390 arch since ino_t doesn't mean "unsigned long" > in s390. alpha uses uint for ino_t as well. It seems a bit pointless - neither arch uses ino_t in ./arch/ code. I suspect both could switch to ulong, which would make the world a slightly better place. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/