Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755082AbbBUChM (ORCPT ); Fri, 20 Feb 2015 21:37:12 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:38199 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754614AbbBUChJ (ORCPT ); Fri, 20 Feb 2015 21:37:09 -0500 Date: Sat, 21 Feb 2015 11:37:03 +0900 (JST) Message-Id: <20150221.113703.2261465491790805448.konishi.ryusuke@lab.ntt.co.jp> To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Martin Schwidefsky , Heiko Carstens Subject: Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode From: Ryusuke Konishi In-Reply-To: <20150220180055.443bbce8.akpm@linux-foundation.org> References: <20150221.092208.1795135375638032743.konishi.ryusuke@lab.ntt.co.jp> <20150221.101328.1613471465739082397.konishi.ryusuke@lab.ntt.co.jp> <20150220180055.443bbce8.akpm@linux-foundation.org> X-Mailer: Mew version 6.6 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 29 On Fri, 20 Feb 2015 18:00:55 -0800, Andrew Morton wrote: > On Sat, 21 Feb 2015 10:13:28 +0900 (JST) Ryusuke Konishi wrote: > >> I've got a warning from 0day kernel testing backend: >> >> fs/nilfs2/btree.c: In function 'nilfs_btree_root_broken': >> >> fs/nilfs2/btree.c:394:3: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'ino_t' [-Wformat=] >> pr_crit("NILFS: bad btree root (inode number=%lu): level = %d, >> flags = 0x%x, nchildren = %d\n", >> ^ >> >> This is output for s390 arch since ino_t doesn't mean "unsigned long" >> in s390. > > alpha uses uint for ino_t as well. > > It seems a bit pointless - neither arch uses ino_t in ./arch/ code. I > suspect both could switch to ulong, which would make the world a > slightly better place. I entirely agree. Regards, Ryusuke Konishi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/