Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176AbbBUJYX (ORCPT ); Sat, 21 Feb 2015 04:24:23 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47872 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbbBUJYT (ORCPT ); Sat, 21 Feb 2015 04:24:19 -0500 Date: Sat, 21 Feb 2015 18:23:08 +0900 From: Mark Brown To: Charles Keepax Cc: lee.jones@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.ok, galak@codeaurora.org, sameo@linux.intel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Message-ID: <20150221092308.GC6236@finisterre.sirena.org.uk> References: <1424257419-28000-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xo44VMWPx7vlQ2+2" Content-Disposition: inline In-Reply-To: <1424257419-28000-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Cookie: for ARTIFICIAL FLAVORING!! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 211.36.148.81 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] mfd: arizona: Move useful defines into a dt-binding include X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1493 Lines: 44 --xo44VMWPx7vlQ2+2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2015 at 11:03:39AM +0000, Charles Keepax wrote: > --- a/include/linux/mfd/arizona/pdata.h > +++ b/include/linux/mfd/arizona/pdata.h > @@ -7,61 +7,17 @@ > * it under the terms of the GNU General Public License version 2 as > * published by the Free Software Foundation. > */ > +#include > =20 > #ifndef _ARIZONA_PDATA_H > #define _ARIZONA_PDATA_H It's a bit odd to have the include outside the guards, is there any great reason for doing so? --xo44VMWPx7vlQ2+2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU6E57AAoJECTWi3JdVIfQRd0H/0TbequL2UmzCGdkzXzYdkhn J5UGuhxnwyPm+ABdx98An/SJKZA5M0p1MnZE1ANe9epwboGb0GZYoDG2BUDIwEnS lLh+B2R7BiOVSaee7sfH2kK6uZWhy0l2vt5Y9S1b2MjZKd1IeCuaX1zTLgbLNIcR 5pFB35z2PgAcVu8qNkjN4VUvs30XAGeCOcxw4U1ObPXiOea8qP0ivl8jEX/6dIek Oqz/V+R47QyLfmvbCyjodKPKW1pihDLfdNr96Fh+vEZLOpoQ/uEQBjdFYYqgVXfV Ugw/Ku8gn2ShOm8V7PpUE83g/7WX0RqBT345mObrdV6V0rGnRG+CBt2YSvT8GQ4= =Y9fs -----END PGP SIGNATURE----- --xo44VMWPx7vlQ2+2-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/