Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190AbbBUJ6N (ORCPT ); Sat, 21 Feb 2015 04:58:13 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:34836 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751946AbbBUJ6F (ORCPT ); Sat, 21 Feb 2015 04:58:05 -0500 Date: Sat, 21 Feb 2015 09:58:04 +0000 From: Al Viro To: Yoshinori Sato Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4 03/15] h8300: Exception and Interrupt handling Message-ID: <20150221095804.GW29656@ZenIV.linux.org.uk> References: <1424505239-7082-1-git-send-email-ysato@users.sourceforge.jp> <1424505239-7082-4-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424505239-7082-4-git-send-email-ysato@users.sourceforge.jp> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 25 On Sat, Feb 21, 2015 at 04:53:47PM +0900, Yoshinori Sato wrote: > +resume_userspace: > + andc #0xbf,ccr > + mov.l sp,er4 > + and.w #0xe000,r4 /* er4 <- current thread info */ > + mov.l @(TI_FLAGS:16,er4),er1 > + and.l #_TIF_WORK_MASK,er1 > + beq restore_all:8 > +work_pending: > + btst #TIF_NEED_RESCHED,r1l > + bne work_resched:8 > + /* work notifysig */ > + mov.l sp,er0 > + subs #4,er0 /* er0: pt_regs */ > + jsr @do_notify_resume > + bra restore_all:8 This is wrong. You really need to handle multiple signals; it ought to reload er1 and recheck it (or just branch to resume_userspace instead) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/