Date: Sat, 21 Feb 2015 11:31:04 +0100
From: Florian Westphal <fw@strlen.de>
To: Tomas Szepe <szepe@pinerecords.com>
Cc: Florian Westphal <fw@strlen.de>, Francois Romieu <romieu@fr.zoreil.com>,
        Hayes Wang <hayeswang@realtek.com>, Eric Dumazet <edumazet@google.com>,
        Tom Herbert <therbert@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Marco Berizzi <pupilla@hotmail.com>, linux-kernel@vger.kernel.org
Subject: Re: 1e918876 breaks r8169 (linux-3.18+)
Message-ID: <20150221103104.GA26574@breakpoint.cc>
References: <20150203100816.GA5807@louise.pinerecords.com>
 <20150203104214.GG24751@breakpoint.cc>
 <20150210154536.GB16264@breakpoint.cc>
 <20150221101512.GB17223@louise.pinerecords.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150221101512.GB17223@louise.pinerecords.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1380
Lines: 39

Tomas Szepe <szepe@pinerecords.com> wrote:
> > I tried to reproduce this without success so far on my RTL8168d/8111d device.
> > I've been running 40 parallel netperf TCP_STREAM tests (1gbit) for the
> > last 5 hours and so far I saw no watchdog tx timeouts.
> > 
> > I'll keep this running for a day or so to see if it just takes more time
> > to trigger.
> 
> So, how's this coming along?  Don't you think the patch should be reverted
> until the problem is diagnosed/understood/fixed?

Sorry.

David, please consider reverting

1e918876853aa85435e0f17fd8b4a92dcfff53d6
(r8169: add support for Byte Queue Limits)

	and

0bec3b700d106a8b0a34227b2976d1a582f1aab7
(r8169: add support for xmit_more)

I cannot reproduce any hangs (tried for 2days with 40 parallel
netperfs using both 100mbit and 1gbit receiver).

And I don't see anything wrong with the change either.
Seems like some revisions of the HW are just dodgy?

I hate giving up, but I have no means to diagnose this any further.
Even reporter says it doesn't affect all of his r8169 nics.

So I think the change is correct per se, but might be revealing some
HW/firmware bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/