Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751488AbbBUPAe (ORCPT ); Sat, 21 Feb 2015 10:00:34 -0500 Received: from smtp2.provo.novell.com ([137.65.250.81]:57403 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbbBUPAd (ORCPT ); Sat, 21 Feb 2015 10:00:33 -0500 Message-ID: <1424530825.6539.7.camel@stgolabs.net> Subject: Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file From: Davidlohr Bueso To: Paul Moore Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Paris , linux-audit@redhat.com Date: Sat, 21 Feb 2015 07:00:25 -0800 In-Reply-To: References: <1424304641-28965-1-git-send-email-dbueso@suse.de> <1424304641-28965-2-git-send-email-dbueso@suse.de> <1424481838.6539.2.camel@stgolabs.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 20 On Sat, 2015-02-21 at 08:45 -0500, Paul Moore wrote: > On Fri, Feb 20, 2015 at 8:23 PM, Davidlohr Bueso wrote: > > On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote: > >> I'd prefer if the audit_log_d_path_exe() helper wasn't a static inline. > > > > What do you have in mind? > > Pretty much what I said before, audit_log_d_path_exe() as a > traditional function and not an inline. Put the function in > kernel/audit.c. well yes I know that, which is why I showed you the code sizes. Now again, do you have any reason? This function will only get less bulky in the future. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/