Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751993AbbBUSLW (ORCPT ); Sat, 21 Feb 2015 13:11:22 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:34670 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbbBUSLU (ORCPT ); Sat, 21 Feb 2015 13:11:20 -0500 Message-ID: <54E8CA45.2010306@kernel.org> Date: Sat, 21 Feb 2015 18:11:17 +0000 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rickard Strandqvist , Hartmut Knaack CC: Lars-Peter Clausen , Peter Meerwald , Greg Kroah-Hartman , Joel Porquet , Darshana Padmadas , Catalina Mocanu , Wolfram Sang , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: iio: trigger: iio-trig-periodic-rtc: Change frequency type to unsigned int References: <1423419774-16753-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1423419774-16753-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2653 Lines: 70 On 08/02/15 18:22, Rickard Strandqvist wrote: > Change struct iio_prtc_trigger_info frequency > type from int to unsigned int. > Since it is always treated as such in the driver > so they type should probably reflect this. > > Signed-off-by: Rickard Strandqvist The only argument against this is that the rtc_irq_set_freq function takes a signed int. Arguably that shouldn't perhaps, but whilst it does we should probably track it's type to avoid confusion. Jonathan > --- > drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > index a24caf7..89df1d3 100644 > --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > @@ -24,7 +24,7 @@ static DEFINE_MUTEX(iio_prtc_trigger_list_lock); > > struct iio_prtc_trigger_info { > struct rtc_device *rtc; > - int frequency; > + unsigned int frequency; > struct rtc_task task; > bool state; > }; > @@ -36,7 +36,7 @@ static int iio_trig_periodic_rtc_set_state(struct iio_trigger *trig, bool state) > > if (trig_info->frequency == 0 && state) > return -EINVAL; > - dev_dbg(&trig_info->rtc->dev, "trigger frequency is %d\n", > + dev_dbg(&trig_info->rtc->dev, "trigger frequency is %u\n", > trig_info->frequency); > ret = rtc_irq_set_state(trig_info->rtc, &trig_info->task, state); > if (ret == 0) > @@ -62,10 +62,10 @@ static ssize_t iio_trig_periodic_write_freq(struct device *dev, > { > struct iio_trigger *trig = to_iio_trigger(dev); > struct iio_prtc_trigger_info *trig_info = iio_trigger_get_drvdata(trig); > - int val; > + unsigned int val; > int ret; > > - ret = kstrtoint(buf, 10, &val); > + ret = kstrtouint(buf, 10, &val); > if (ret) > goto error_ret; > > @@ -74,10 +74,8 @@ static ssize_t iio_trig_periodic_write_freq(struct device *dev, > if (ret == 0 && trig_info->state && trig_info->frequency == 0) > ret = rtc_irq_set_state(trig_info->rtc, > &trig_info->task, 1); > - } else if (val == 0) { > - ret = rtc_irq_set_state(trig_info->rtc, &trig_info->task, 0); > } else > - ret = -EINVAL; > + ret = rtc_irq_set_state(trig_info->rtc, &trig_info->task, 0); > if (ret) > goto error_ret; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/